avirajkhare00 commented on code in PR #2976:
URL: https://github.com/apache/iggy/pull/2976#discussion_r2968903254
##########
helm/charts/iggy/templates/deployment.yaml:
##########
@@ -44,7 +44,7 @@ spec:
{{- end }}
serviceAccountName: {{ include "iggy.serviceAccountName" . }}
securityContext:
- {{ toYaml .Values.server.podSecurityContext | nindent 8 }}
+ {{ toYaml .Values.podSecurityContext | nindent 8 }}
Review Comment:
1. added guradrails
2. Agreed. The UI should not need the server’s `io_uring`-related security
settings. I’d prefer to handle that in a follow-up by splitting security
settings into `server.*` and `ui.*` values rather than widening this PR further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
