avirajkhare00 commented on PR #2983: URL: https://github.com/apache/iggy/pull/2983#issuecomment-4103170364
I pushed a cleanup pass on this PR. I removed the cache-control header from /healthz and kept the route focused on a stable 200 ok response, since headers are not a reliable contract once the route is prerendered and served from build output. I also dropped the ad hoc route test and the node --test script for now, because this package does not have an established web test harness yet and I did not want to grow scope just to keep a one-off colocated test. The Helm change remains the same: UI liveness and readiness now probe /healthz. I verified the change with the repo-standard web checks: npm ci, npm run lint, npm run build, and npm run build:static, and confirmed the static build emits the healthz artifact. I also validated the chart path in kind by building the patched iggy-web-ui image, loading it into the cluster, deploying a fresh UI-only Helm release, and checking the live service. The pod came up 1/1 with 0 restarts, and GET /healthz returned 200 OK with body ok. One thing that showed up in the live runtime is that Content-Type is not a durable part of this contract either: the deployed prerendered route did not preserve a meaningful Content-Type header. That further supports keeping the probe contract to status and body only. I left startupProbe out of this PR to keep it narrowly scoped to the dedicated UI health endpoint and probe-path fix, but I can add that as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
