T1B0 commented on code in PR #3182:
URL: https://github.com/apache/iggy/pull/3182#discussion_r3181407847
##########
foreign/node/src/bdd/stream.ts:
##########
@@ -52,3 +52,11 @@ Then(
assert.ok(await this.client.stream.delete({streamId}));
}
);
+
+After(async function (this: TestWorld) {
Review Comment:
this cleanup should not be part of this MR. at the moment we restart a
server with --fresh arg to ensure a clean state. bdd test could create other
object not cleaned up by this too (users, tokens ...). i think one way to
really fix this for all SDK would be to add a deleting/cleaning BDD test and
play it at the end, but it's outside of this issue/MR scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
