hubcio commented on code in PR #3235:
URL: https://github.com/apache/iggy/pull/3235#discussion_r3225365689
##########
.github/workflows/pre-merge.yml:
##########
@@ -78,6 +78,19 @@ jobs:
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+ # PHP SDK
+ test-php:
+ name: PHP • ${{ matrix.task }}
+ needs: detect
+ if: ${{ fromJson(needs.detect.outputs.php_matrix).include[0].component !=
'noop' }}
+ strategy:
+ fail-fast: false
+ matrix: ${{ fromJson(needs.detect.outputs.php_matrix) }}
+ uses: ./.github/workflows/_test.yml
+ with:
+ component: ${{ matrix.component }}
+ task: ${{ matrix.task }}
+
Review Comment:
whole CI part of this PR is completely invalid. please investigate how other
languages are tested and rewrite it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
