jayakasadev opened a new issue, #3376:
URL: https://github.com/apache/iggy/issues/3376

   `core/server-ng/src/bootstrap.rs` still imports from `core/server`:
   
   ```rust
   use server::bootstrap::{create_directories, create_shard_executor};
   ```
   
   `create_shard_executor` already lives in `server_common::executor` after 
#3331 — the `server::bootstrap` path is just a re-export.
   
   `create_directories` is still only in `core/server/src/bootstrap.rs:93`. 
It's a thin wrapper over `SystemConfig` filesystem paths with no 
`server`-internal state, so it belongs in `server_common`.
   
   **Proposed:**
   
   1. Move `create_directories` to `core/server_common/` (e.g. 
`server_common::bootstrap`).
   2. Keep a `pub use` re-export in `core/server/src/bootstrap.rs` so legacy 
`server` is unaffected.
   3. In `core/server-ng/src/bootstrap.rs`, replace the single import with:
      ```rust
      use server_common::bootstrap::create_directories;
      use server_common::executor::create_shard_executor;
      ```
   
   After this PR, `server-ng` has zero `use server::bootstrap::*` imports. The 
other `use server::*` clusters (logging, shard allocator, segment/offset 
storage, legacy user/crypto, root env constants) are separate follow-ups under 
#3315.
   
   **Done when:** no `use server::bootstrap::*` in `core/server-ng/`, legacy 
`server` still builds via re-export, full CI green.
   
   Tracker: #3315. Predecessor: #3331.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to