chengxilo commented on code in PR #3379:
URL: https://github.com/apache/iggy/pull/3379#discussion_r3329585987
##########
foreign/go/client/tcp/tcp_core.go:
##########
@@ -71,6 +72,8 @@ type config struct {
reconnection tcpClientReconnectionConfig
// noDelay disable Nagle's algorithm for the TCP connection
noDelay bool
+ // logger is the logger used for internal diagnostics
Review Comment:
```suggestion
```
You already have it as attribute at type IggyTcpClient.
##########
foreign/go/client/tcp/tcp_core.go:
##########
@@ -71,6 +72,8 @@ type config struct {
reconnection tcpClientReconnectionConfig
// noDelay disable Nagle's algorithm for the TCP connection
noDelay bool
+ // logger is the logger used for internal diagnostics
Review Comment:
```suggestion
```
You already have it as attribute at type IggyTcpClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
