hubcio commented on code in PR #3380:
URL: https://github.com/apache/iggy/pull/3380#discussion_r3332792862
##########
foreign/php/composer.json:
##########
@@ -1,14 +1,95 @@
{
"name": "apache/iggy-php",
"description": "PHP extension bindings for Apache Iggy.",
+ "type": "php-ext",
Review Comment:
flagging for the eventual publish path (out of scope here): public packagist
can't register a package whose `composer.json` lives in a repo subdirectory -
it references the source repo root and won't zip subtrees
[packagist#472](https://github.com/composer/packagist/issues/472). there's no
root `composer.json` or split tooling, so `apache/iggy-php` isn't installable
from this monorepo as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
