AmalenduManoj opened a new pull request, #3403:
URL: https://github.com/apache/iggy/pull/3403
## Which issue does this PR address?
Relates to #3315
## Rationale
`server-ng` still imported bootstrap helpers from the legacy `server` crate.
Moving directory bootstrap into `server_common` continues the shared-server
extraction work and removes one `server::bootstrap` dependency from `server-ng`.
## What changed?
`create_shard_executor` already lived in `server_common`, but `server-ng`
still imported it through `server::bootstrap`. `create_directories` also lived
only in `server::bootstrap`, which kept `server-ng` coupled to the legacy
server bootstrap module.
`create_directories` now lives in `server_common::bootstrap`, with a small
`SystemPaths` trait so shared code can use system path accessors without
creating a crate dependency cycle. The legacy
`server::bootstrap::create_directories` path remains available through a
re-export, and `server-ng` imports both helpers directly from `server_common`.
## Local Execution
- Passed:
- `cargo fmt --all`
- `cargo sort --no-format --workspace`
- `cargo clippy --all-targets --all-features -- -D warnings`
- `cargo build`
- `cargo machete`
- `cargo test -p server_common -p configs -p server -p server-ng`
- `rg '^use server::bootstrap::' core/server-ng/`
- Full `cargo test` was started but not completed because unrelated external
connector integration tests failed or hung locally.
- Pre-commit hooks not ran.
## AI Usage
AI tools were used.
1. Tool: ChatGPT/Codex.
2. Scope: implementation help, refactor guidance, and local verification
commands.
3. Verification: ran formatting, cargo sort, clippy, build, machete, focused
tests for touched crates, and the issue-specific `rg` check.
4. Yes, I can explain every line of the change if asked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
