chengxilo commented on code in PR #3384:
URL: https://github.com/apache/iggy/pull/3384#discussion_r3341803240
##########
bdd/docker-compose.coverage.yml:
##########
@@ -52,7 +55,7 @@ services:
- sh
- -c
- >-
- go test -v ${GO_TEST_EXTRA_FLAGS}
+ go test -v
Review Comment:
`-race` and coverage serve different purposes, `-race` flag won't benefit
the coverage flag. So I removed it intentionally. However, I think I can print
a log to warn that `./scripts/run-bdd-tests.sh --coverage go-race` won't use
-race flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
