kriti-sc commented on issue #2927: URL: https://github.com/apache/iggy/issues/2927#issuecomment-4702550907
Today the sink runtime configures consumers with AutoCommit::When(AutoCommitWhen::PollingMessages) ([runtime/src/sink.rs:421](https://github.com/apache/iggy/discussions/runtime/src/sink.rs#L421)), meaning offsets are committed when messages are polled — before they are processed. A failed batch is silently lost. **Sink must have an option to decide exactly when it is safe to advance the offset, as only the sink knows when a write is truly durable from the target's perspective.** This decision of what to do with the i32 returned by the connector (act vs keep it cosmetic) affects enabling the sink to drive offset commits as well. cc @spetz @hubcio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
