mfyuce commented on PR #3523: URL: https://github.com/apache/iggy/pull/3523#issuecomment-4762722574
@ryerraguntla — judgment call on the circuit breaker: The existing `build_retry_client` wraps a `HttpRetryMiddleware` that already retries 429 and 5xx with exponential backoff, and the `PermanentHttpError` mapping cuts retries for permanent 4xx errors (bad data won't hammer the backend). Ingest throughput is also naturally rate-bounded by `batch_length` and `poll_interval`. QuickWit is typically an internal service in the same cluster, so prolonged partition is rare, and the runtime already isolates failures per connector. A full half-open / trip-threshold circuit breaker on top of this would add complexity without clear benefit for this specific sink. Happy to revisit if the second reviewer sees a concrete failure mode that the existing retry policy doesn't cover. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
