mfyuce commented on PR #3525:
URL: https://github.com/apache/iggy/pull/3525#issuecomment-4766261573

   Rebased onto upstream master -- PR now contains only the InvalidOffset fix 
(2 commits, 1 file: `core/sdk/src/clients/consumer.rs`).
   
   Per your feedback on per-partition tracking: replaced `Arc<AtomicBool>` with 
`Arc<DashMap<u32, ()>>` keyed by `partition_id`. An InvalidOffset on partition 
A no longer forces `PollingStrategy::first()` on partitions B, C, etc. For 
auto-assign consumers (`partition_id = None`) `u32::MAX` is used as a sentinel; 
behavior for that case is equivalent to before.
   
   The earlier comments about `partial_success` and `try_send` in 
`otlp_source/server.rs` belong to PR #3516 -- happy to address them there if 
you want to continue that review.
   
   /ready


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to