slbotbm opened a new pull request, #3559: URL: https://github.com/apache/iggy/pull/3559
## Which issue does this PR address? <!-- We generally require a GitHub issue for all bug fixes and enhancements. Link it with GitHub syntax, keep the line that applies and delete the other: - `Closes #123` auto-closes the issue when this PR merges (full fix). - `Relates to #123` links without closing (partial or related work). --> Closes # Relates to #2100 ## Rationale <!-- Why is this change needed? If the issue explains it well, a one-liner is fine. --> Additions of more functions and tests in the cpp sdk. ## What changed? <!-- 2-4 sentences. Problem first (before), then solution (after). GOOD: "Messages were unavailable when background message_saver committed the journal and started async disk I/O before completion. Polling during this window found neither journal nor disk data. The fix freezes journal batches in the in-flight buffer before async persist." GOOD: "When many small messages accumulate in the journal, the flush passes thousands of IO vectors to writev(), exceeding IOV_MAX (1024 on Linux)." BAD: - Walls of text - "This PR adds..." (we can see the diff) --> - decouples delete_connection from logout_user function. - adds logout_user, update_stream, store_consume_offset, get_consumer_offset, delete_consumer_offset, and flush_unsaved_buffer functions - adds tests for join_consumer_group and leave_consumer_group, which were missing previously. Added cleanup related to consumer groups as well. - All conversion code was moved into type_conversions.rs for ease of finding. - Also added consumer and producer types for high-level api, and commented-out method signatures for the rest of the remaining functions in lib.rs ## Local Execution - Passed - Pre-commit hooks ran <!-- You must run your code locally before submitting. "Relying on CI" is not acceptable - PRs from authors who haven't run the code will be closed. Did you have `prek` installed? It runs automatically on commit and covers all project languages. See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md). --> ## AI Usage <!-- If AI tools were used, please answer: 1. Which tools? codex 2. Scope of usage? code generation, researcg 3. How did you verify the generated code works correctly? tested it, read through it 4. Can you explain every line of the code if asked? yes If no AI tools were used, write "None" or delete this section. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
