hubcio opened a new pull request, #3579: URL: https://github.com/apache/iggy/pull/3579
Both the binary GetSnapshot handler and HTTP POST /snapshot only called ensure_authenticated, unlike sibling read-server endpoints (get_stats, get_clients) which also check read_servers. Any authenticated caller, including one with no granted permissions, could trigger a host-wide diagnostic dump: process and /proc network tables, kernel info, concatenated server logs, and current_config.toml. Add perm_get_snapshot, mirroring perm_get_stats (read_servers or manage_servers), and invoke it after authentication on both transports. The HTTP handler previously discarded the identity; it now passes user_id into the check. The existing permission suite never exercised snapshot, which is why the gap went unnoticed; extend it to assert an unprivileged user is rejected and read_servers/manage_servers users are not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
