slbotbm commented on code in PR #3581: URL: https://github.com/apache/iggy/pull/3581#discussion_r3492323508
########## foreign/python/src/consumer_group.rs: ########## Review Comment: a separate consumer group file is not needed. Inline all of the code in this into consumer.rs ########## foreign/python/src/consumer_group.rs: ########## @@ -0,0 +1,147 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use iggy_common::{ + ConsumerGroup as RustConsumerGroup, ConsumerGroupDetails as RustConsumerGroupDetails, + ConsumerGroupMember as RustConsumerGroupMember, +}; +use pyo3::prelude::*; +use pyo3_stub_gen::derive::{gen_stub_pyclass, gen_stub_pymethods}; + +#[gen_stub_pyclass] +#[pyclass] +pub struct ConsumerGroup { + pub(crate) inner: RustConsumerGroup, +} + +impl From<RustConsumerGroup> for ConsumerGroup { + fn from(group: RustConsumerGroup) -> Self { + Self { inner: group } + } +} + +#[gen_stub_pymethods] +#[pymethods] +impl ConsumerGroup { + #[getter] + pub fn id(&self) -> u32 { + self.inner.id + } + + #[getter] + pub fn name(&self) -> String { + self.inner.name.to_string() + } + + #[getter] + pub fn partitions_count(&self) -> u32 { + self.inner.partitions_count + } + + #[getter] + pub fn members_count(&self) -> u32 { + self.inner.members_count + } +} + +#[gen_stub_pyclass] +#[pyclass] +pub struct ConsumerGroupDetails { + pub(crate) inner: RustConsumerGroupDetails, +} + +impl From<RustConsumerGroupDetails> for ConsumerGroupDetails { + fn from(group: RustConsumerGroupDetails) -> Self { + Self { inner: group } + } +} + +#[gen_stub_pymethods] +#[pymethods] +impl ConsumerGroupDetails { + #[getter] + pub fn id(&self) -> u32 { + self.inner.id + } + + #[getter] + pub fn name(&self) -> String { + self.inner.name.to_string() + } + + #[getter] + pub fn partitions_count(&self) -> u32 { + self.inner.partitions_count + } + + #[getter] + pub fn members_count(&self) -> u32 { + self.inner.members_count + } + + #[getter] Review Comment: Is the getter tag truly useful for this function? I think this would error if used as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
