mfyuce commented on PR #3523: URL: https://github.com/apache/iggy/pull/3523#issuecomment-4856591504
/ready Hi @ryerraguntla, I have resolved the conflicts and cleaned up the branch: 1. **Rebase**: Rebased the branch on `origin/master` (upstream master) and cleanly isolated the quickwit connector commits, purging any unrelated commits. 2. **Prechecks**: Verified that formatting (`cargo fmt`), clippy, whitespaces, and newlines checks pass perfectly. 3. **Payload Handling**: Brought the connector further up to project conventions by adding support for `Payload::Raw` (tries parsing JSON, falls back to Base64 wrapping if binary/non-JSON) and `Payload::Text` (wrapped inside a JSON object) to match the elasticsearch connector behavior. 4. **Performance**: Optimized the NDJSON generation logic during ingestion to build the payload using a single string buffer and avoid intermediate vector allocations. 5. **Testing**: Added comprehensive unit tests for the conversion logic. All 11 unit tests pass cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
