hubcio commented on code in PR #3562:
URL: https://github.com/apache/iggy/pull/3562#discussion_r3509429297
##########
core/server-ng/src/users.rs:
##########
@@ -31,8 +31,7 @@ use iggy_binary_protocol::codec::{WireDecode, WireEncode};
use iggy_binary_protocol::requests::users::{ChangePasswordRequest,
CreateUserRequest};
use iggy_binary_protocol::{Operation, RequestHeader};
use iggy_common::IggyError;
-use server::streaming::utils::crypto;
-use server_common::Message;
+use server_common::{Message, crypto};
Review Comment:
since crypto now comes from `server_common`, the `argon2` and `rand`
dependencies declared in `core/server-ng/Cargo.toml` are fully dead - nothing
in `core/server-ng/src` uses either crate directly (crypto was always consumed
via this import, previously through the legacy `server` path). both also sit in
the `cargo-machete` ignored list in that manifest, so machete will never flag
them. worth dropping the two deps plus their two machete-ignore entries to
finish the cleanup this PR starts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
