hubcio commented on code in PR #3581:
URL: https://github.com/apache/iggy/pull/3581#discussion_r3518829084
##########
foreign/python/Cargo.toml:
##########
@@ -38,6 +38,7 @@ doc = false
bytes = "1.12.0"
futures = "0.3.32"
iggy = { path = "../../core/sdk", version = "0.10.1-edge.2" }
+iggy_common = { path = "../../core/common", version = "0.10.1-edge.2" }
Review Comment:
noticed this right before merging - do we actually need the `iggy_common`
dep? the rust sdk (`iggy`) already re-exports these through its prelude, just
not all of them: `ConsumerGroupDetails` is there but `ConsumerGroup` and
`ConsumerGroupMember` aren't. looks like an oversight - the prelude exports
both base and details for `Stream` and `Topic`, but only `Details` for consumer
groups.
cleaner fix: add `ConsumerGroup` and `ConsumerGroupMember` to
`core/sdk/src/prelude.rs` (both are already pub at the `iggy_common` root - the
sdk's own binary consumer-group client already imports `ConsumerGroup` from
there), then drop this dep and pull the whole family from `iggy::prelude` like
the other wrappers. one less dependency, and it fixes the prelude gap for the
next consumer too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
