seokjin0414 commented on code in PR #3554: URL: https://github.com/apache/iggy/pull/3554#discussion_r3521987813
########## bdd/cpp/.bazelrc: ########## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +common --enable_bzlmod Review Comment: and it caught its first real drift on the very first ci run: master merged #3598 (foreign/cpp rules_cc 0.2.19 → 0.2.20) after this branch's lock was generated, and ci builds the merge commit — so resolution wanted rules_cc 0.2.20 files the lock didn't know about. update mode would have re-resolved silently; error mode failed loudly. rebased onto master, synced bdd/cpp to rules_cc 0.2.20 and regenerated the lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
