hubcio commented on code in PR #3615:
URL: https://github.com/apache/iggy/pull/3615#discussion_r3542813098
##########
core/configs/src/server_config/sharding.rs:
##########
@@ -101,6 +101,10 @@ const fn default_inbox_capacity() -> usize {
DEFAULT_INBOX_CAPACITY
}
+const fn default_pin_cores() -> bool {
+ true
+}
Review Comment:
dont do it like so, default value should be read from toml, see how other
config fields default values are assumed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
