hubcio opened a new pull request, #3633:
URL: https://github.com/apache/iggy/pull/3633
Legacy core/server and server-ng shared one ShardingConfig, coupling
their config surfaces: server-ng-only knobs (inbox_capacity, shutdown
and reconcile timers) leaked into legacy, and both read each other's
static defaults. Since server-ng is meant to replace core/server,
legacy's config surface must be independently deletable.
Fork the type. Legacy keeps {cpu_allocation, pin_cores}; server-ng
owns the full six-field type plus its *_MAX bounds and validation.
SystemConfig becomes generic over the sharding type with the legacy
variant as the default param, so the legacy server compiles untouched
and only configs and server-ng need edits. Each server's config.toml
is now the single source of truth for its defaults.
Making SystemConfig generic exposed the ConfigEnv derive emitting the
struct name in expression position (SystemConfig::CONST) without
generics, breaking inference; it now emits the env-var string directly.
Add struct-level serde(default) on the server-ng type so every field
falls back to its frozen default, matching the legacy type's behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
