kriti-sc commented on code in PR #2886:
URL: https://github.com/apache/iggy/pull/2886#discussion_r3550187860


##########
core/integration/tests/connectors/fixtures/clickhouse/container.rs:
##########
@@ -0,0 +1,297 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::connectors::fixtures;
+use integration::harness::TestBinaryError;
+use reqwest::Client as HttpClient;
+use reqwest::header::{HeaderMap, HeaderValue};
+use serde::Deserialize;
+use std::time::Duration;
+use testcontainers_modules::testcontainers::core::{IntoContainerPort, WaitFor};
+use testcontainers_modules::testcontainers::runners::AsyncRunner;
+use testcontainers_modules::testcontainers::{ContainerAsync, GenericImage, 
ImageExt};
+use tokio::time::sleep;
+use tracing::info;
+
+const CLICKHOUSE_IMAGE: &str = "clickhouse/clickhouse-server";
+const CLICKHOUSE_TAG: &str = "25.1";
+const CLICKHOUSE_HTTP_PORT: u16 = 8123;
+
+pub const CLICKHOUSE_TEST_USER: &str = "default";
+pub const CLICKHOUSE_TEST_PASSWORD: &str = "iggy_test";
+
+pub const HEALTH_CHECK_ATTEMPTS: usize = 60;
+pub const HEALTH_CHECK_INTERVAL_MS: u64 = 500;
+pub const DEFAULT_POLL_ATTEMPTS: usize = 100;
+pub const DEFAULT_POLL_INTERVAL_MS: u64 = 100;
+
+pub const DEFAULT_TEST_STREAM: &str = "test_stream";
+pub const DEFAULT_TEST_TOPIC: &str = "test_topic";
+pub const DEFAULT_DATABASE: &str = "default";
+pub const DEFAULT_SINK_TABLE: &str = "iggy_messages";
+
+pub const ENV_SINK_URL: &str = 
"IGGY_CONNECTORS_SINK_CLICKHOUSE_PLUGIN_CONFIG_URL";
+pub const ENV_SINK_DATABASE: &str = 
"IGGY_CONNECTORS_SINK_CLICKHOUSE_PLUGIN_CONFIG_DATABASE";
+pub const ENV_SINK_TABLE: &str = 
"IGGY_CONNECTORS_SINK_CLICKHOUSE_PLUGIN_CONFIG_TABLE";
+pub const ENV_SINK_USERNAME: &str = 
"IGGY_CONNECTORS_SINK_CLICKHOUSE_PLUGIN_CONFIG_USERNAME";
+pub const ENV_SINK_PASSWORD: &str = 
"IGGY_CONNECTORS_SINK_CLICKHOUSE_PLUGIN_CONFIG_PASSWORD";
+pub const ENV_SINK_INSERT_FORMAT: &str =
+    "IGGY_CONNECTORS_SINK_CLICKHOUSE_PLUGIN_CONFIG_INSERT_FORMAT";
+pub const ENV_SINK_STRING_FORMAT: &str =
+    "IGGY_CONNECTORS_SINK_CLICKHOUSE_PLUGIN_CONFIG_STRING_FORMAT";
+pub const ENV_SINK_STREAMS_0_STREAM: &str = 
"IGGY_CONNECTORS_SINK_CLICKHOUSE_STREAMS_0_STREAM";
+pub const ENV_SINK_STREAMS_0_TOPICS: &str = 
"IGGY_CONNECTORS_SINK_CLICKHOUSE_STREAMS_0_TOPICS";
+pub const ENV_SINK_STREAMS_0_SCHEMA: &str = 
"IGGY_CONNECTORS_SINK_CLICKHOUSE_STREAMS_0_SCHEMA";
+pub const ENV_SINK_STREAMS_0_CONSUMER_GROUP: &str =
+    "IGGY_CONNECTORS_SINK_CLICKHOUSE_STREAMS_0_CONSUMER_GROUP";
+pub const ENV_SINK_PATH: &str = "IGGY_CONNECTORS_SINK_CLICKHOUSE_PATH";
+
+/// DDL for the test table — matches the `TestMessage` struct.
+pub const CREATE_TABLE_SQL: &str = "
+    CREATE TABLE IF NOT EXISTS iggy_messages (

Review Comment:
   resolving but lmk thoughts/pushback.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to