seokjin0414 opened a new issue, #3634:
URL: https://github.com/apache/iggy/issues/3634

   ### Bug description
   
   Follow-up from #3554 
([discussion](https://github.com/apache/iggy/pull/3554#discussion_r3512938253)):
 the C++ BDD suite got `--strict` there, but per that thread the rust and go 
runners have the same hole — if a shared feature file gains a step without a 
matching definition, the suite reports it and still exits 0, so CI stays green 
while steps silently stop running.
   
   - **rust** (`bdd/rust/tests/basic_messaging.rs`, 
`bdd/rust/tests/leader_redirection.rs`): both entry points use cucumber's 
default `World::run`, which treats an unmatched step as skipped and doesn't 
fail on skipped. Fix: `Self::cucumber().fail_on_skipped().run_and_exit(...)` in 
both (the feature files use no tag filtering, so nothing is legitimately 
skipped).
   - **go** (`bdd/go/tests/suite_test.go`): godog is non-strict by default and 
neither `godog.Options` block sets `Strict`. Fix: `Strict: true` in both suites.
   
   The other runners (node/java/python/csharp) are strict by default per the 
discussion above, so no changes needed there.
   
   Taking this one (as discussed in the PR thread) — will follow with a PR. 
Verification will mirror the C++ change: prove the red path before calling it 
done.
   
   ### Affected area / component
   
   Rust SDK, Go SDK, CI / build / tooling
   
   ### Deployment
   
   Not applicable
   
   ### Versions
   
   master (`2fc6ff6eb`)
   
   ### Hardware / environment
   
   _No response_
   
   ### Sample code
   
   _No response_
   
   ### Logs
   
   _No response_
   
   ### Iggy server config
   
   _No response_
   
   ### Reproduction
   
   1. Append a bogus step (e.g. `And the server should sing a lullaby`) to 
`bdd/scenarios/basic_messaging.feature`
   2. `./scripts/run-bdd-tests.sh rust` (or `go`)
   3. The runner reports the step as undefined/skipped and the suite still 
exits 0
   
   ### Contribution
   
   - [x] I'm willing to submit a pull request to fix this bug
   
   ### Good first issue
   
   - [ ] I think this could be a good first issue for a new contributor
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to