ethanlin01x commented on code in PR #3690:
URL: https://github.com/apache/iggy/pull/3690#discussion_r3604638063
##########
foreign/python/pyproject.toml:
##########
@@ -149,6 +149,14 @@ filterwarnings = [
[tool.uv]
exclude-newer = "7 days"
+cache-keys = [
+ { file = "pyproject.toml" },
+ { file = "Cargo.toml" },
+ { file = "Cargo.lock" },
+ { file = "src/**/*.rs" },
Review Comment:
Would it make sense to also include the workspace root manifest here?
{ file = "../../Cargo.toml" }
My understanding is that since foreign/python is excluded from the root
workspace, but core/sdk inherits most of its dependency versions and features
from [workspace.dependencies] in the root Cargo.toml, a version bump there
could change the build without any of the current cache keys noticing — so uv
sync might keep the previously built .so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
