mattp5657 commented on code in PR #3640:
URL: https://github.com/apache/iggy/pull/3640#discussion_r3611524832
##########
core/connectors/sources/postgres_source/src/lib.rs:
##########
@@ -303,10 +301,6 @@ impl PostgresSource {
}
async fn setup_cdc(&self) -> Result<(), Error> {
Review Comment:
I resolved this but also handled two other edge cases.
1. `capture_operations` - an entry outside `INSERT`/`UPDATE`/`DELETE` (e.g.
a typo like `INSRT`) previously passed startup silently and would just never
match, quietly dropping that operation type forever.
2. `payload_format` - an unsupported value (e.g. `btea` instead of `bytea`)
would similarly pass startup and only surface as a failure deep in row
processing on the first poll, not at startup.
Both now validate in `open()` alongside `cdc_backend`, before `setup_cdc()`
runs, so any of the three fails loudly at startup instead of leaving a
`Running` connector that silently drops or mishandles data.
Then I rewrote the integration test to make sure it covered this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
