ryerraguntla commented on PR #3654:
URL: https://github.com/apache/iggy/pull/3654#issuecomment-5017739488
Bunch of nits, but needs to be looked into and fixed
1. messages_processed counts failed batches
- yet README:118 claims loaded-only (lib.rs:237-238) ·
- upload_parquet has no retry while COPY does (:381-399) ·
- naive-micros→TIMESTAMPTZ UTC assumption (:596-598) ·
- lossy as i32/as i64 casts (:649,661) ·
- empty s3_prefix → malformed archive key (:413-414) ·
2. dead params_per_row return (:330-363) ·
3. invalid crates.io category "warehouse" → "database" (Cargo.toml:25) ·
4. const ICEBERG_SINK_KEY = "redshift" copy-paste (int.rs:36) ·
5. "IcebergFixture" error strings + "bytea" fixture doc mislabels (fixtures
sink.rs:393,429,198,245,292) ·
6. typos "Reshift"/"vis S3"/"Reshshift"/"We dont" ·
7. payload_column Vec churn + uncompressed parquet writer
Did you check "typos" as part of precheck?
Good effort. Thanks for chiming in to contribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
