ryerraguntla commented on PR #3497: URL: https://github.com/apache/iggy/pull/3497#issuecomment-5111948025
Few comments/Nits : Please compare the config params like batch size and timeout have the same default values like other connectors. Regarding , explain what the timeout value means. Is it for every retry or cumulative retries timeout value. Give an example in the readme.md file. Other than this observation, I approve the changes and good for merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
