mfyuce commented on PR #3523: URL: https://github.com/apache/iggy/pull/3523#issuecomment-5176408204
/ready > @mfyuce - while I review, please add the issue it is closing and the motivation for implementing. Follow the published Iggy PR template . Try to add code coverage to the maximum possible with out significantly increasing the test time. Done, all three. Closes #3814, opened for the gaps this PR fixes. Description rewritten to the template with the motivation. On coverage: the sink had no tests, this adds 11 covering payload handling (JSON, raw JSON, raw text, raw binary, unsupported), config defaults, and index_id extraction. They are pure functions with no I/O, so the suite runs in under a second. The four integration tests in core/integration/tests/connectors/quickwit/ are unchanged and pass against a real Quickwit container, so total test time is unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
