krishvishal commented on code in PR #3733:
URL: https://github.com/apache/iggy/pull/3733#discussion_r3728698168
##########
foreign/cpp/src/client.rs:
##########
Review Comment:
This and `iggy.hpp:389-395` says destroying the client releases the
connection. `IggyClient::connect` spawns a heartbeat holding its own `Arc` to
the transport, exiting only on `ClientShutdown`, so the socket, the server
session and the ping loop all survive. Same reason `:488` ("no effect when
already connected") is false and the `:501-505` reuse cycle leaks a task per
cycle. Worth filing upstream: store the `JoinHandle` discarded at
`clients/client.rs:250` and abort it in a `Drop for IggyClient`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
