krishvishal commented on code in PR #3824:
URL: https://github.com/apache/iggy/pull/3824#discussion_r3734784974
##########
core/partitions/src/poll_plan.rs:
##########
@@ -533,14 +536,23 @@ impl DiskReadPlan {
faulted = true;
break 'walk;
};
- let consumed = walk_disk_chunk(
+ let ChunkWalk { consumed, corrupt } = walk_disk_chunk(
&chunk,
query,
count,
&mut matched,
&mut fragments,
&mut last_matching_offset,
+ self.validate_checksum,
Review Comment:
On the `Faulted` sub-point: not adding a client error in this pass.
The poll reply has no error channel at all — `resolve_poll_request` failures
already flatten to an empty body — so adding one is an SDK-visible change on
every client. Recorded at the fault site instead, including why an empty poll
is a fair answer for a transient IO fault and a wrong one for at-rest
corruption that never recovers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
