mlevkov commented on issue #3848:
URL: https://github.com/apache/iggy/issues/3848#issuecomment-5229371455
One more data point that narrows the fix. `None` has exactly two callers,
and both are the restart path:
```
core/connectors/runtime/src/manager/sink.rs:261 .get_sink_config(key,
None)
core/connectors/runtime/src/manager/source.rs:280 .get_source_config(key,
None)
```
Every other caller passes `Some(version)` (`api/{sink,source}.rs` serving
`/configs/{version}`). So changing what `None` resolves to in the local
provider cannot affect anything but restart, which is the behaviour the issue
is about.
That leaves one decision I would rather not guess at: what `None` should
return when a key has configs but no active version recorded.
`get_active_configs` already has a rule for that case; making the accessor
match it would keep one definition of "active" rather than two.
Happy to send the PR once you say which way you want it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
