kriti-sc commented on code in PR #3658:
URL: https://github.com/apache/iggy/pull/3658#discussion_r3750374846
##########
.github/workflows/_build_rust_artifacts.yml:
##########
@@ -238,13 +251,16 @@ jobs:
outdir="dist/${target}"
mkdir -p "${outdir}"
- plugins="${{ inputs.connector_plugins }}"
- IFS=',' read -ra pkgs <<< "$plugins"
+ IFS=',' read -ra pkgs <<< "$CONNECTOR_PLUGINS"
for pkg in "${pkgs[@]}"; do
lib_name="$(echo "$pkg" | xargs)"
[[ -z "$lib_name" ]] && continue
so_file="target/${target}/release/lib${lib_name}.so"
- [[ -f "$so_file" ]] && cp "$so_file" "${outdir}/"
+ if [[ ! -f "$so_file" ]]; then
+ echo "::error::expected connector plugin artifact missing:
${so_file}. The plugin crate built no cdylib, or its name does not match
lib<crate>.so." >&2
+ exit 1
Review Comment:
this was successful ^^ build completed within 15 minutes, both cold
target | runner | result | wall clock
-- | -- | -- | --
x86_64-unknown-linux-gnu | ubuntu-latest | success | 12m56s
aarch64-unknown-linux-gnu | ubuntu-24.04-arm | success | 9m34s
<br class="Apple-interchange-newline">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
