haubur opened a new pull request, #3882:
URL: https://github.com/apache/iggy/pull/3882

   ## Which issue does this PR address?
   
   Closes #3881
   
   ## Rationale
   store_offset(None) for a standalone consumer deletes offset partition 0 
   
   ## What changed?
   store_offset(None) behaves correct for a consumer in a consumer group 
because the server
   resolves what partition the member currently is assigned to.
   For a standalone consumer the server resolves via unwrap_or(0) always 
deleting the offset for partition 0.
   The fix checks if `None`is passed to delete_offset() AND whether the 
consumer is standalone (via the is_consumer_group flag). In that case take the 
current_partition_id tracked by the consumer itself.
   If the consumer is a member of the consumer group, the server still resolves 
the partition id.
   Note, actual fix in consumer.rs. Test failed previously (comp. issue), now 
passes. 
   
   ## Local Execution
   - Passed
   - Pre-commit hooks ran
   
   ## AI Usage
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to