ethanlin01x commented on code in PR #3877:
URL: https://github.com/apache/iggy/pull/3877#discussion_r3792505609
##########
foreign/python/tests/test_message_operations.py:
##########
Review Comment:
One note on the invalid string identifier: `Consumer` just holds a
`PyIdentifier`, and the conversion only happens inside `poll_messages`. So
`Consumer.Single("")` builds fine and you don't get `ValueError: Invalid
identifier` until the poll, which is where the test catches it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
