ethanlin01x commented on PR #3891: URL: https://github.com/apache/iggy/pull/3891#issuecomment-5312162438
@haubur Thanks for the review. I agree that using `NonZeroIggyDuration` is cleaner than checking in each method. My concern is that some of these are cross-field rules, so I am not sure a type can enforce them. For example, `interval = 0` is still valid when `max_retries` is bounded. Changing the field type would also be a breaking change for the SDK API. So I would prefer to keep the current approach. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
