kriti-sc commented on code in PR #3951:
URL: https://github.com/apache/iggy/pull/3951#discussion_r3836046000
##########
core/connectors/runtime/src/sink.rs:
##########
@@ -748,6 +748,18 @@ async fn process_messages(
);
let ffi_elapsed = ffi_start.elapsed();
+ // The status code is the plugin's only channel for reporting a failed
write:
+ // the SDK returns non-zero when the sink's consume() errors or the batch
cannot
+ // be deserialized. Ignoring it would count the batch as processed and
advance
+ // consumer offsets over messages the sink never stored — the same
silent-loss
+ // class that the iggy_sink_open status check prevents at startup.
Review Comment:
while I agree that the plugin should exit when plugin returns non-zero
status, simply exitting the plugin does not solve the problem highlighted in
the issue.
I think we should fix the comment and update the issue description to
reflect this.
Also see discussion: https://github.com/apache/iggy/issues/2927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
