mlevkov commented on PR #3797: URL: https://github.com/apache/iggy/pull/3797#issuecomment-5383655551
Closing this alongside #3795, per your call on Discord. Without the bounded channel there is no backpressure for `block_in_place` to hand off: master's `flume::unbounded()` send never parks, and `handle_messages` awaits the batch-result oneshot immediately after the callback returns, which yields the worker at that point anyway. The discipline this PR was arguing for also already landed in the direction that genuinely blocks, since the runtime invokes `batch_result_callback` inside `tokio::task::spawn_blocking` because the plugin runs its async `on_batch_result` to completion inside that FFI call. #3796 is still open. Happy to close it too, or reframe it around the 30s timeout case, whichever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
