haubur commented on code in PR #3953:
URL: https://github.com/apache/iggy/pull/3953#discussion_r3854463738


##########
core/sdk/src/clients/producer_dispatcher.rs:
##########
@@ -192,6 +180,8 @@ impl ProducerDispatcher {
             }
         }
 
+        // After shards are closed await the error callback task,
+        // that might drain queued errors from the final flush.
         if let Err(e) = self._join_handle.await {

Review Comment:
   True. Didnt touch it, but removed the prefix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to