chengxilo commented on code in PR #3923: URL: https://github.com/apache/iggy/pull/3923#discussion_r3876378937
########## core/integration/tests/server/cluster_metadata_advertised.rs: ########## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! `node.advertised_address` on a cluster-disabled server: what a client is +//! told about the one node in the roster. +//! +//! Without a roster the server has only its own bind address to reason from, +//! and a bind address answers which interfaces it accepts on - never where a +//! client reaches it. Behind any NAT (published container ports, a Service, a +//! load balancer) the two are different addresses, and this setting is the +//! only way to state the second one. The bind-derived fallback and the empty +//! answer for a wildcard bind are pinned at unit level (`cluster_meta.rs`) +//! and across the SDKs in `bdd/`; what needs a real server is that a declared Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
