djanand opened a new pull request, #3994: URL: https://github.com/apache/iggy/pull/3994
## Which issue does this PR address? <!-- We generally require a GitHub issue for all bug fixes and enhancements. Link it with GitHub syntax, keep the line that applies and delete the other: --> - Closes #3993 ## Rationale The zero thread-pool limit was skipped only on macOS aarch64, so an Intel macOS build applied it and panicked on the first fs operation with "the thread pool is needed but no worker thread is running". compio's polling driver routes fs through the blocking pool on all of macOS, not just Apple Silicon, which is what the comment above the cfg already described and what the FIXME removed in 8ed41c7db said before it. <!-- Why is this change needed? If the issue explains it well, a one-liner is fine. --> ## What changed? The zero `thread_pool_limit` was skipped on macOS `aarch64`, so an Intel macOS build applied it and panicked on the first fs operation with "the thread pool is needed but no worker thread is running". The fix now covers `target="macOS"` regardless of architecture. The related comment in `message_writer.rs` is updated to match and drop a reference to a FIXME removed in 8ed41c7db. <!-- 2-4 sentences. Problem first (before), then solution (after). GOOD: "Messages were unavailable when background message_saver committed the journal and started async disk I/O before completion. Polling during this window found neither journal nor disk data. The fix freezes journal batches in the in-flight buffer before async persist." GOOD: "When many small messages accumulate in the journal, the flush passes thousands of IO vectors to writev(), exceeding IOV_MAX (1024 on Linux)." BAD: - Walls of text - "This PR adds..." (we can see the diff) --> ## Local Execution - [x] Passed - [x] Pre-commit hooks ran <!-- You must run your code locally before submitting. "Relying on CI" is not acceptable - PRs from authors who haven't run the code will be closed. Did you have `prek` installed? It runs automatically on commit and covers all project languages. See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md). --> ## AI Usage If AI tools were used, please answer: 1. Which tools? Claude 2. Scope of usage? To debug stacktrace and location of error 3. How did you verify the generated code works correctly? Pre-produced the panic before change, made the change, built and booted the server, confirmed GET /ping returns 200 and completed stream/topic/send/poll round trip via the cli. cargo fmt --all --check and clippy clean 4. Can you explain every line of the code if asked? Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
