loadingalias commented on PR #3999: URL: https://github.com/apache/iggy/pull/3999#issuecomment-5482377188
Hey @hubcio. Thanks for the quick review. I genuinely didn't realize that the ASF projects had the guard in place. It makes sense. So, I'm going to prepare and submit the cargo-rail-action to the ASF for review. I've got some cleanup and patches to make w/ respect to the compiler fight I'm in, but when it's green - I will submit. I don't see it taking longer than today, or maybe tomorrow. I'm really glad that I ran cargo-rail across Iggy. I've found a handful of simple bugs and one significant issue w/ the compiler work. These will get patched in v0.26.0. With respect to 'unify' - yes... it's independent of the GHA. A simple `cargo binstall cargo-rail` does the trick. You can run `cargo rail unify --check` to see what's what. `unify --check` doesn't modify manifests; it exits 1 when it finds a pending dep-coherence change. For this PR, I can either revise it to avoid the external action for now or return with the exact approved SHA after ASF review... whatever is less disruptive for you guys. TBH, I would prefer to return post ASF review. Just give me a day or two? Discord - no, I find it to be a time sink and I just don't have that luxury. Cargo-Rail is a side quest because my own storage engine & query engine work needed it. I say this to say... I'm just too busy. Haha. I will join, though. It's easier to communicate there, for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
