krishvishal commented on PR #3975: URL: https://github.com/apache/iggy/pull/3975#issuecomment-5505902581
The three out-of-diff items from the review body are fixed too: - `partition_helpers.rs:528` and `shard/lib.rs:3677` no longer name `should_increment_offset`; they say `OffsetSpace` / `OffsetSpace::append_live`. - `state_transfer.rs:2172` chains `anchor_cleanup_path` after `.log` and `.index`, with a comment recording that it is unreachable today because anchors are solo-only. All six round-3 items are in the working tree, not in a push yet, so this head still shows none of them. Verification after the six: `fmt`, `sort --no-format`, `clippy --all-features --all-targets -D warnings` clean; 1005 unit tests across partitions, configs, server, shard and consensus; `cluster::crash_offset_reuse` 6/6 on a rebuilt server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
