mlevkov opened a new pull request, #4059: URL: https://github.com/apache/iggy/pull/4059
Closes #3982. Wording is @hubcio's from [this comment](https://github.com/apache/iggy/issues/3982#issuecomment-5546601424), applied verbatim, scoped as @justinmclean suggested: keep the forwarding comment, drop the "name every finding before closing" bullet. Two changes to `## Close Policy`: **Where findings go.** Whoever closes leaves a comment saying why, and a finding that outlives the change gets its own issue linked from that comment. #3795 to #3981 is the worked example: the close was correct once #3855 removed the premise, but the surviving half sat in a closed thread for days and only surfaced because someone asked whether anything had been dropped. **The stale timing.** The old line read "Inactivity for longer than 7 days". It now points at a new `### Stale PRs` subsection. I checked each claim in that subsection against `.github/workflows/` rather than taking the numbers on trust: | Claim | Where it comes from | | --- | --- | | 7 days to label, 7 more to close | `days-before-pr-stale: 7`, `days-before-pr-close: 7` in `stale-prs.yml`; the close message itself says "inactive for 14 days" | | Push, comment, review, reopen, ready-for-review clear it | `stale-prs-unmark.yml` on `[synchronize, reopened, ready_for_review]`, and `stale-prs-unmark-on-activity.yml` via `pr-triage-collect.yml` on `issue_comment: created` / `pull_request_review: submitted` | | The bot does not clear its own label | `remove-stale-when-updated: false` | | Drafts and `pinned` exempt | `exempt-draft-pr: true`, `exempt-pr-labels: "pinned"` | | Issues never labeled or closed | `days-before-issue-stale: -1`, `days-before-issue-close: -1`, and the job grants only `pull-requests: write` | Deliberately left out, per @hubcio: the `exempt-pr-labels: pinned,S-waiting-on-review` idea and the `/pin` command. Both are workflow changes and belong in their own PR. `markdownlint` passes on `CONTRIBUTING.md` and repo-wide with the script's own invocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
