richardcocks opened a new issue, #4078:
URL: https://github.com/apache/iggy/issues/4078

   ### Bug description
   
   The `MAX_PAYLOAD_SIZE` in rust message construction was increased from 10MB 
to 64MB in PR #2341 
   
   ```diff
   - /// * Maximum payload size: 10 MB
   + /// * Maximum payload size: 64 MB
   
   - pub const MAX_PAYLOAD_SIZE: u32 = 10 * 1000 * 1000;
   + pub const MAX_PAYLOAD_SIZE: u32 = 64 * 1000 * 1000;
   ```
   
   This change wasn't reflected in the Go SDK, which remains enforcing a 10MB 
limit.
   
   ```go
        //  - Maximum payload size: 10 MB
        MaxPayloadSize = 10 * 1000 * 1000
   ```
   
   The Node, C# and Java SDKs don't enforce a limit, and can send messages 
>64MB as long as they still fit within 64MiB, the maximum frame size:
   
   ```rust
   /// Equivalent to `MessageBusConfig::default().max_message_size`; kept in
   /// sync with the [`crate::MessageBusConfig::default`] impl. Retained as
   /// a named const for test ergonomics and for callers that have no
   /// `IggyMessageBus` in scope (e.g. standalone handshake helpers).
   pub const MAX_MESSAGE_SIZE: usize = 64 * 1024 * 1024;
   ```
   
   These are accepted on the non-HTTP ingress. HTTP validates each payload 
against `MAX_PAYLOAD_SIZE`. The server core only relies on the frame being 
valid.
   
   ### Affected area / component
   
   Go SDK
   
   ### Deployment
   
   Not applicable
   
   ### Versions
   
   Go SDK master
   
   ### Hardware / environment
   
   N/A
   
   ### Sample code
   
   _No response_
   
   ### Logs
   
   _No response_
   
   ### Iggy server config
   
   _No response_
   
   ### Reproduction
   
   _No response_
   
   ### Contribution
   
   - [ ] I'm willing to submit a pull request to fix this bug
   
   ### Good first issue
   
   - [x] I think this could be a good first issue for a new contributor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to