7487 commented on PR #4018: URL: https://github.com/apache/iggy/pull/4018#issuecomment-5564349028
Thanks for the second pass. Everything is addressed inline in b76b445 (docstrings mirror the server semantics, stub regenerated, auth/permission/topology/bounds tests added, Rust unit test for the `None` semver branch), and master is merged again. Two things worth knowing while reading the tests: the SDK has no `disconnect` or `delete_stream`, so `logout_user` stands in for the post-disconnect case and topology cleanup deletes topics rather than streams; and `threads_count` is 0 when the server runs on macOS (sysinfo cannot enumerate threads there), so that assertion is skipped when the server reports `os_name == "Darwin"`. Local run against a server built from this branch: `pytest tests/ --ignore=tests/test_tls.py` 509 passed; fmt, clippy (`-D warnings`), `cargo test`, ruff and pyrefly clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
