hubcio commented on code in PR #4063:
URL: https://github.com/apache/iggy/pull/4063#discussion_r3947244629
##########
core/shard/src/lib.rs:
##########
@@ -9830,8 +9872,16 @@ fn rotate_sweep_to_cursor(namespaces: &mut
[IggyNamespace], cursor: Option<IggyN
namespaces.rotate_left(namespaces.partition_point(|namespace| *namespace <
cursor));
}
-/// Whether this replica holds adopted suffix HEADERS above `commit_max` whose
-/// bodies never arrived.
+fn partition_repair_fetch_to_op(
+ commit_min: u64,
+ commit_max: u64,
+ missing_suffix: Option<u64>,
Review Comment:
Warning: Returning the adopted suffix head while `commit_min < commit_max`
makes the repair request span the committed prefix this replica already holds.
This VSR change is unrelated to consumer offset quotas; split it into its own
PR.
##########
core/partitions/src/iggy_partition.rs:
##########
@@ -4075,6 +4675,12 @@ where
let (frozen_batches, index_bytes, flush_index, batch_count,
committed_info, chunk_len) = {
let segment = self.log.active_segment();
let mut file_position = segment.size.as_bytes_u64();
+ let persisted_end = if file_position == 0 {
Review Comment:
Nit: The `persisted_end` fix is segment-flush idempotence for a repaired
batch, unrelated to consumer offset quotas. Split it out so it can be reverted
independently.
##########
core/bench/src/benchmarks/common.rs:
##########
@@ -44,7 +44,11 @@ pub async fn create_consumer(
"Consumer #{} → joining consumer group #{}",
consumer_id, consumer_group_id
);
- let cg_identifier =
Identifier::try_from(*consumer_group_id).unwrap();
+ // By name: the group was created by name and the server assigns
its
Review Comment:
Nit: The consumer group addressing fixes here and at line 216 are unrelated
to consumer offset quotas. Split them into their own commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
