richardcocks commented on code in PR #4076:
URL: https://github.com/apache/iggy/pull/4076#discussion_r3947371940
##########
foreign/java/java-sdk/src/main/java/org/apache/iggy/serde/BytesSerializer.java:
##########
@@ -340,7 +339,9 @@ private static long batchChecksum(
*/
private static byte[] encodedMessageId(MessageId id) {
if (id.toBigInteger().signum() == 0) {
- return readAllBytes(new
UuidMessageId(UUID.randomUUID()).toBytes());
+ byte[] minted = new byte[16];
+ ThreadLocalRandom.current().nextBytes(minted);
Review Comment:
@spetz - I have pushed a new MessageIdGenerator class for Java with test
coverage. I've also done end-to-end tests to confirm the performance is good.
I can explain what it is doing and why it works, although some of my Java
knowledge is slightly confused by 20 years of C#, so I sometimes make bad
assumptions about the details in Java.
I have not had time to de-claude the language in the comments for the class,
but I have set "allow maintainer fixes" for this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
