mmodzelewski commented on code in PR #4068:
URL: https://github.com/apache/iggy/pull/4068#discussion_r3948975436
##########
foreign/java/java-sdk/src/test/java/org/apache/iggy/message/MessageTest.java:
##########
@@ -72,6 +73,14 @@ void
ofCreatesMessageWhenGivenMessageHeaderPayloadAndNullUserHeaders() {
assertThat(message.userHeaders().size()).isEqualTo(0);
}
+ @Test
+ void ofEncodesStringPayloadAsUtf8() {
Review Comment:
I think it's not worth it spawning a separate test suite just for it. From
JDK 18, UTF-8 is the default. Before 18, ISO-8859-1 would only be set on
Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
