richardcocks opened a new issue, #4111:
URL: https://github.com/apache/iggy/issues/4111
### Bug description
The connectors runtime test `path_without_extension_gets_os_suffix` fails on
windows because `resolve_plugin_path` resolves on windows to `"dll"`, but the
test re-implements the logic without the windows arm.
The pattern matching is unnecessary because
`std::env::consts::DLL_EXTENSION` can be used instead.
### Affected area / component
Connectors
### Deployment
_No response_
### Versions
_No response_
### Hardware / environment
_No response_
### Sample code
Old prod:
```rust
let os_extension = match std::env::consts::OS {
"macos" => "dylib",
"windows" => "dll",
_ => "so",
};
```
Old test:
```rust
let expected_ext = match std::env::consts::OS {
"macos" => "dylib",
_ => "so",
};
```
Proposal for both: `std::env::consts::DLL_EXTENSION`.
### Logs
_No response_
### Iggy server config
_No response_
### Reproduction
_No response_
### Contribution
- [x] I'm willing to submit a pull request to fix this bug
### Good first issue
- [ ] I think this could be a good first issue for a new contributor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
