gkoszyk opened a new issue, #4138: URL: https://github.com/apache/iggy/issues/4138
#4132 lands 11 regression tests as `#[ignore]` so CI stays green. Each carries the defect in its ignore reason, and each still **fails** under `cargo test -- --ignored` — they are live reproductions, not placeholders. Inventory: ``` grep -rn '#\[ignore = "PR #4092' core/ cargo test -p <crate> --lib -- --ignored ``` ### Work items - [ ] #4133 — persisted durability has no fault coverage (4 tests, incl. 1 pre-existing). Also covers the test that **still does not exist**: that a persisted ack survives lost unsynced writes. - [ ] #4134 — a refused consumer-offset write downs the whole node (3 tests, one of them an open decision) - [ ] #4135 — checkpoint barrier taken through a fresh descriptor (1 test) - [ ] #4136 — WAL coalescing gated on body bytes instead of the WAL extent (1 test) - [ ] #4137 — server refuses to boot on sibling `IGGY_*` variables (2 tests) ### Related, not covered by #4132 - #4128 — purge records completion after the offset-directory sync fails. Same neighbourhood as #4135, different call site (purge rather than checkpoint). The hazard is already documented in-code at `iggy_partition.rs:7548-7555`. Reproducible with machinery that predates #4132: `fail_at(n, FaultMode::Before)` on `StorageOperation::DirectorySync` plus `Crash::PowerLoss`. ### Background These came out of an adversarial review of #4092 (4 reviewers, 3 rounds, cross-checked). Of that PR's 144 prior review threads — all marked resolved — three criticals were found resolved-but-not-fixed; they are #4133, #4134 and #4136. Two findings are deliberately **not** filed here: the Helm `configVersion: auto` render failure and the mixed-policy produce-admission coupling at `iggy_partition.rs:798`. Both were judged warnings rather than criticals, and neither has a test in #4132. Backwards-compatibility findings were dropped by decision: a stored `enforce_fsync = true` is a one-way upgrade gate with no online escape (`boot/recovery.rs:98-107`, `UPDATABLE_TOPIC_OPTION_KEYS` at `options/mod.rs:480-484`), accepted as a consequence of #4092 being a breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
